-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix ListPullRequestsWithCommit option type #2822
Fix ListPullRequestsWithCommit option type #2822
Conversation
Co-Authored-By: vgnshiyer <vgnshiyer@asu.edu>
Thank you, @RickleAndMortimer ! |
Fixes: #2815. |
Codecov Report
@@ Coverage Diff @@
## master #2822 +/- ##
=======================================
Coverage 98.06% 98.06%
=======================================
Files 136 136
Lines 12279 12279
=======================================
Hits 12041 12041
Misses 162 162
Partials 76 76
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @RickleAndMortimer !
LGTM.
Awaiting second LGTM+Approval from any other contributor to this repo before merging.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Thank you, @valbeat ! |
* fix(deps): update module github.com/google/go-github/v53 to v55 * fix: address API breaking changes - google/go-github#2822 * fix: stop using deprecated API github.NewEnterpriseClient --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Shunsuke Suzuki <suzuki.shunsuke.1989@gmail.com>
ListPullRequestsWithCommit
usesPullRequestListOptions
as one of it's parameters. This is incorrect because in GitHub's documentation, the endpoint for this function,repos/%v/%v/commits/%v/pulls
, does not share the same parameters as the ones defined inListPullRequestsWithCommit
go-github/github/pulls.go
Lines 119 to 141 in 96726d8
This PR simply sets the correct options, ListOptions, for the ListPullRequestWithCommit.
see #2815 for more details